Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto hint id #431

Open
ClementWalter opened this issue Jan 15, 2025 · 0 comments
Open

refacto hint id #431

ClementWalter opened this issue Jan 15, 2025 · 0 comments
Milestone

Comments

@ClementWalter
Copy link
Member

Why

Currently, we use a single raw snake_cased_name string as hint it and match this string both in python and in rust. This is limiting to have more generic hints like memory[ap + i] = const where we currently need one hint per i.

What

Make hints parametrized as Cairo 1 hints are, see also https://github.com/starkware-libs/cairo/blob/40a7b60687682238f7f71ef7c59c986cc5733915/crates/cairo-lang-runner/src/casm_run/mod.rs#L1681

How

Consider that the raw string is a json string and not just an idea. serde this string both in python and rust to get the hint implementation.

@ClementWalter ClementWalter moved this to Backlog in Keth Jan 15, 2025
@Eikix Eikix added this to the Optimization milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants