Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up HandWaveyManager.java #9

Open
1 of 3 tasks
ksandom opened this issue Feb 10, 2022 · 3 comments
Open
1 of 3 tasks

Clean up HandWaveyManager.java #9

ksandom opened this issue Feb 10, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ksandom
Copy link
Owner

ksandom commented Feb 10, 2022

Task

  • Move as much functionality as possible out into dedicated, tested classes.
  • Remove as many unused/obsolete variables as possible.
  • Linting passes.

Background

This class is where everything has evolved the most, and it's showing it now. Getting this class into a cleaner shape will make the project much more approachable to new-comers.

I'm reserving this ticket for myself because I want it done in a specific way.

@ksandom ksandom added the enhancement New feature or request label Feb 10, 2022
@ksandom ksandom self-assigned this Feb 10, 2022
@ksandom
Copy link
Owner Author

ksandom commented Nov 27, 2023

This is in progress in the ksandom/codeClean branch. This is a first iteration clean. Further cleans will happen over time in separate releases.

@ksandom
Copy link
Owner Author

ksandom commented Nov 27, 2023

Good news

I have the linter working.

Bad news

It seems that I am very over-due for having done this. It's going to take me a while to work through everything.

I might do a release tomorrow to get the the main branch up to date with the latest fixes and clean-ups, before continuing with the clean-up.

@ksandom
Copy link
Owner Author

ksandom commented Nov 28, 2023

The first code clean PR has just been merged, and included in the latest release. It's the first of what will probably be a few steps towards better code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant