-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run/build scripts: replace hard coded docker CR with what is available in user's local env #1352
base: main
Are you sure you want to change the base?
run/build scripts: replace hard coded docker CR with what is available in user's local env #1352
Conversation
Signed-off-by: Saumyacodes-40 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Saumya40-codes. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
At many places, such solution already exists in the repo. So I've carry forwarded the same approach to check for |
Signed-off-by: Saumyacodes-40 <[email protected]>
/test check-provision-k8s-1.30 |
Test passes! If its all right, then this file also needs to be changed accordingly so I can update it! |
What this PR does / why we need it:
Currently at few place in bash scripts we were using
docker
as the only option which might not be suitable to user using another (likepodman
)This PR, replaces such hardcoded
docker
instance and replacing them with the container runtime of the user's local envWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1306
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note:
cc: @dhiller @brianmcarey