Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Provide an API to control deployment of dynamic networks controller #1380

Open
orelmisan opened this issue Feb 16, 2025 · 2 comments
Open
Labels
help wanted Identifies an issue that has been specifically created or selected for new contributors. kind/enhancement kind/proposal sig/network

Comments

@orelmisan
Copy link
Member

Is your feature request related to a problem? Please describe:
Currently, most SIG-network lanes use Multus v3 without the dynamic-networks-controller.
We are interested in having Multus v4 deployed on all lanes owned by SIG-network.

kubevirtci provides the following configuration options: Multus v3 or Multus v4 with the dynamic-networks-controller.
We would like to have the ability to configure CNAO to deploy Multus V4 without the dynamic-networks-controller.

The following environment variables are enabled on most SIG-network lanes:

  • KUBEVIRT_WITH_MULTUS_V3=true
  • KUBEVIRT_WITH_CNAO=true

They cause kubevirtci to invoke gocli with the following command line options:

  • --deploy-multus
  • --enable-cnao

When these two command line options are enabled, CNAO is configured to not deploy Multus and the dynamic-networks-controller.

Describe the solution you'd like:
A new environment variable could be introduced in order to enable / disable the deployment of the dynamic-networks-controller.

Describe alternatives you've considered:
A clear and concise description of any alternative solutions or features you've considered.

Additional context:
Following the adjustments of lane to use Multus v4, support for Multus v3 deployment could be dropped.

@dhiller
Copy link
Contributor

dhiller commented Feb 17, 2025

/help

@kubevirt-bot
Copy link
Contributor

@dhiller:
This request has been marked as needing help from a contributor.

Guidelines

  • No Barrier to Entry
  • Clear Task
  • Solution Explained
  • Provides Context
  • Identifies Relevant Code
  • Gives Examples
  • Ready to Test
  • Goldilocks priority
  • Up-To-Date

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added the help wanted Identifies an issue that has been specifically created or selected for new contributors. label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Identifies an issue that has been specifically created or selected for new contributors. kind/enhancement kind/proposal sig/network
Projects
None yet
Development

No branches or pull requests

3 participants