Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install_requires and setup_requires #23

Open
GokulNC opened this issue Jun 30, 2020 · 3 comments
Open

Improve install_requires and setup_requires #23

GokulNC opened this issue Jun 30, 2020 · 3 comments

Comments

@GokulNC
Copy link

GokulNC commented Jun 30, 2020

I did a pip install ., but I get the following error when transliterating:

FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Program Files (x86)\\Python37-32\\lib\\site-packages\\libindic\\transliteration\\cmudict.0.7a_SPHINX_40'

Solution:
https://python-packaging.readthedocs.io/en/latest/non-code-files.html

Please fix the issue with the given solution to include all non-code files.

@asdofindia
Copy link
Collaborator

f5653c1 dropped MANIFEST.in in favour of setuptools-git

I dropped the setuptools-git dependency in b751902 without knowing this. My bad.

Let me fix that.

@GokulNC
Copy link
Author

GokulNC commented Jun 30, 2020

Thanks @asdofindia

Is it possible to add install_requires in the setup.py to include setuptools and also other dependencies from requirements.txt ?

@asdofindia asdofindia changed the title FileNotFoundError: [Errno 2] No such file or directory: libindic/transliteration/cmudict.0.7a_SPHINX_40 Improve install_requires and setup_requires Jul 1, 2020
@asdofindia
Copy link
Collaborator

I'm unsure about that.

Cons:

  • Duplicating the list of dependencies risks these going out of sync

Pros:

  • Easy installation?

This answer says we can put a . in requirements.txt and use install_requires to actually list down dependencies.

I think I'll try that. @santhoshtr @copyninja

@asdofindia asdofindia reopened this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants