Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support #8

Open
longears opened this issue Sep 29, 2012 · 5 comments
Open

Python 3 support #8

longears opened this issue Sep 29, 2012 · 5 comments

Comments

@longears
Copy link
Owner

I've only tried this code on Python 2.6.1.

Do the dependencies support Python 3?

@mart-e
Copy link

mart-e commented Oct 4, 2012

I had a look and, no, the macauthlib is not compatible python 3. It fails almost every unittest when used with python 3. At least it's dependency WebOb is compatible python 3 so it shouldn't be impossible to port macauthlib.

Edit: actually it may not be a problem for a long time anymore :) mozilla-services/macauthlib#4

@longears
Copy link
Owner Author

longears commented Oct 4, 2012

Great!

Or if we decide to move away from macauthlib there was an almost-working attempt at MAC Authentication in an old version of our own code:
https://github.com/longears/python-tent-client/blob/e6a2c32b7c0d81e8b6cd9fe1361578227f189d8e/tentapp.py#L33-71
The server never accepted it, though. I think the hostname might be thing that was wrong about it.

@johankj
Copy link

johankj commented Oct 4, 2012

I just implemented authentication in PHP. If you don't mind, I could take a look at it. Then we can get rid of macauthlib and requests containing url-escaped chars should work.

@longears
Copy link
Owner Author

longears commented Oct 4, 2012

Sure! _authHook would need to be updated to pull the hostname out of the request object and then sign it using the old MAC auth code.

@johankj
Copy link

johankj commented Oct 4, 2012

I've got it working now, but got some git-issues. I'll fix them later tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants