-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Keep track if ffmpeg is installed #33
Comments
I've briefly looked into the feasibility of including ffmpeg, and it's not looking great so far.
Given the different sources, this means a different download & extraction (including compression algorithm) solution for each, potentially different versioning for each, etc. This also doesn't include that we may not be able to properly validate all releases, as it looks like some of them aren't signed. If I could find a single source that provides variants for all major operating systems, using all-git or all-release based builds, with some kind of signing key, that would be super helpful. Otherwise, I think this will be very low priority on the list. |
Thanks for your feedback. I will also google a little bit if I find something. I also thought about it again and my idea was maybe to just have an option for MustInstall to check if ffmpeg is installed? So it's returning an error and informing the user to install ffmpeg instead of failing in middle of a download process like it did for me? This would be good to know beforehand if you download an hour long (or longer) video. |
I don't know if that's something that should be enabled by default (as I think there are various things you can do with yt-dlp that don't require ffmpeg), but I could see an option to install being "CheckFFMpeg" or similar. |
Yeah I also woudln't activate it by default (also for backwards compatibility and like you said, if someone doesn't need ffmpeg) but as an option if you want to check for it. |
✨ Describe the feature you'd like
At the moment it is checked if yt-dlp is installed and otherwise it will install it. The same would be cool to have for ffmpeg as its e.g. used to extract audio of a download or put together audio and video after downloading the best quality.
🌧 Is your feature request related to a problem?
I have yt-dlp configured to extract audio of a youtube video and ffmpeg is not installed, it will fail and return with the error:
So it would be a good feature to also install ffmpeg if it's not present when calling
MustInstall
orInstall
.🔎 Describe alternatives you've considered
The only alternative is to give the user an error if ffmpeg is not installed if they want to run the tool or if I want to integrate it somewhere else. Or I need to make sure, I'll bring ffmpeg, so it will be always present.
⚠ If implemented, do you think this feature will be a breaking change to users?
No
⚙ Additional context
No response
🤝 Requirements
The text was updated successfully, but these errors were encountered: