-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcuts Ignored After Upgrade #247
Comments
Not reproducible. Make sure you've upgraded to 1.0.0 properly, not partially. If you think a piece of info is missing, please add it. |
I have a similar or maybe the same issue both on manjaro and arch, after an update, but not one from lxqt.
|
What do you mean by "not one from lxqt"? |
An update from arch I suppose, because I didn't change anything, it's the "family" pc, did just updating, will check more now. |
I have done a full system update, including everything of lxqt. Not sure what else to do. Confirming stefonarch's finding: In Session Settings, Global Keyboards Shortcuts is ticket (enabled) but not running. Starting manually fixes the issue temporarily, i.e. during the session. Will address downstream at arch linux. |
Strange! I have Manjaro Testing, update it regularly (an update came last night) and reboot it after updates. Is it possible that the problem is in Arch's package of |
I rebooted Manjaro right now, after checking upgrades and finding none. We should find what causes this for you. Re-opening until it's found.... |
In the meantime I was testing on my arch machine.
Settings for removable device plugin:
Volume plugin:
BTW cool that we can save notifications now :) |
If I remember well I also tried once renaming |
|
The only difference I can see is ALSA instead of PulseAudio. Anyway, your problem is not that |
@stefonarch |
I can confirm and reproduce this bug on Arch and Endeavour OS with LXQT, but not on Manjaro LXQT. (!?) |
It can be reproduced in a Virtulabox VM as well with fresh Arch install (2021 december iso) with LXQT. |
Maybe related to collision with Openbox shortcut settings ? |
At least that explains why the daemon can't start. Now the question is why the X11 connection breaks on Arch. Which display manager do you use on Arch and which is used on Manjaro LXQt? |
I have this issue on Archlinux. It happenes since few days, last system update: yesterday. Manual start of global keys daemon solves it for one session. Window manager: OpenBox |
Please tell which window manager and display manager (aka. login manager) you use. Do you all use Openbox as WM? What happens if you change it? Do you use LightDM, SDDM, or... for the display manager? I couldn't reproduce the problem after 5 reboots. My display manager is SDDM. As for WM, I use sometimes KWin, sometimes compiz-reloaded. I don't have Openbox and my Manjaro Testing is up-to-date. |
BTW, by chance, I saw that |
Some answers from me:
I see this in manjaro:
|
@stefonarch The problem that's described here is that EDIT: "Cannot grab shortcut...." is a message produced by |
alt+tab doesn't matter IMO. |
Ok, I've nailed down something probably: In manjaro VM it never happened also after update, but it started doing it when adding a second panel on the left or right. |
I have two panels :P EDIT:
|
A shot in the dark: @stefonarch Set |
The problem is that it is random, atm I cannot reproduce it at all anymore in manjaro VM. So this with the panels was coincident probably. Manjaro testing is more ahead, but still behind arch? |
It may not be related to that. If we assume that X11 breaks, it may be related to the graphic driver and an update that triggers the problem with it. We're still in the dark. Did you test |
That may also be possible. |
I can't work in this way; should find a computer with which I can see the problem firsthand. Working with VMs is painful because they're too slow. My old computer hasn't been updated for 6 months and I prefer to keep it that way for comparison (has been useful on many occasions). I might patch its libx11 if I find the time. |
OK. On my older laptop (Asus — this one is Lenovo), I applied the suspicious patch to libx11 1.7.2, recompiled and installed the latest lxqt-globalkeys, added 10 instances of main menu (as @slidinghotdog had suggested), and did NOT use lxqt/lxqt-session#406. Then I did 8 cold boots, two reboots and several logouts — I removed There is an unknown factor. EDIT: The unknown factor may be that both computers are powerful gaming laptops. |
Good news: Bad news: |
Lxqt-Session 1.0.1 is released; it restarts the module on exit(1). When it comes to your distro, please remove any other workaround that you may have used for this issue. Most probably, the issue isn't caused by our code but we'll do our best to make sure of that or circumvent it in |
@stefonarch, @avallach2000, @antis81 First, I put lxqt-globalkeys/daemon/core.cpp Line 1032 in ea9de14
By doing so, I succeeded in reproducing the issue inside the session and after startup. Almost every time I started Then, understandably, I just changed lxqt-globalkeys/daemon/core.cpp Lines 880 to 881 in ea9de14
To void Core::log(int level, const char *format, ...) const
{ return;
After that, I haven't had a single instance of exit(1). If anyone has an explanation, I'm all ears. |
Negative... 2 restarts → always errors messages, 4 session restarts 1 error. |
OK, it happened to me too, after 15 or 16 tries. Still, I don't understand why |
The aforementioned observation lead me to this (which is probably used for debugging): lxqt-globalkeys/daemon/core.cpp Line 991 in ea9de14
So, I changed it to (I could have commented it out too): XSynchronize(mDisplay, False); I can't trust my magical system but no exit(1) after 8 boots. Sorry, I'm tired of so many startups... |
It seems to work, but I'm unsure about side-effects this may cause. |
@tsujan, @avallach2000 Actually no need to call XSynchronize. XOpenDisplay should do this job perfectly! EDIT: With this change in #248 XFlush now also does have an effect (leaving it out deadlocks)! |
One reboot and 2 relogin without errors with only that change here. |
@antis81 , yes. As I mentioned, commenting out is enough. @avallach2000, @stefonarch
As far as I know, it shouldn't have any side effect. I'll make a PR and try to explain the situation in it. Last but not least, obstinacy pays off ;) Thank you all. |
|
The end result seems good; the whole process was a nightmare that apparently ended with 2021 ;) |
Otherwise, after a recent libx11 commit, the app might exit with code 1 (see the comment inside the code). Closes #247
Or simply merge #248. :) |
On many occasions, we need to check previous commits. Therefore, we should keep the changes as pertinent as possible. In this case, only the removal of synchronization was needed. In general, unnecessary code changes should be avoided. |
lxqt-globalkeysd is such an unnecessary piece of code I'm not going to waste any more time :) |
Otherwise, after a recent libx11 commit, the app might exit with code 1 (see the comment inside the code). Closes #247
I run Manjaro and was having the issue on almost every reboot. I noticed it was possible to start lxqt-globalkeysd after the desktop was up and then everything would work. #!/bin/bash Then I edited 2 lines in /etc/xdg/autostart/lxqt-globalkeyshortcuts.desktop to
So far its worked on every reboot (about 20) except 1 when it was at sleep 5 so I boosted that to 10. |
Tomorrow the fix will be merged probably, so lxqt-globalkeys-1.0.1 should show up soon in your updates. |
Yes, we agreed on testing the fix (which is already in git) for a week before putting it in lxqt-globalkeys-1.0.1. Perhaps we were overcautious but we'll release it tomorrow. It'll quickly appear among the updates of Arch and then Manjaro. |
I have the same issue, I think the issue appeared with 1.0.0.4, but is still there with 1.0.1-1 $ lxqt-globalkeysd
The X11 connection broke: No error (code 0)
X connection to :0 broken (explicit kill or server shutdown).
QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread $ sudo lxqt-globalkeysd
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
[Critical] Cannot register service 'org.lxqt.global_key_shortcuts'
[Notice] Stopped Dunno right now about XDG_RUNTIME_DIR, I'm not used to debug it atm... EDIT: |
@Loader009 |
Yes, my fault, I thought it was installed yesterday - I noticed with pacman -Qi that it was still an older version. - sorry! |
It's OK. To see the change, a logout and login is also needed. |
Expected Behavior
After upgrading lxqt shortcut keys are expected to work as before
Current Behavior
Upgrading lxqt, in particular lxqt-globalkeys (0.17.0-1 -> 1.0.0-1), shortcut keys ceased working. Further, configuration tool "Global Actions Manager" is empty/does not list shortcuts although file $HOME/.config/lxqt/globalkeyshortcuts.conf still exists and has proper content. Adding new shortcuts in config tool is also not working because all buttons are disabled. globalkeyshortcuts.conf has rw entitlements for user, group and others.
Possible Solution
Running out of ideas...
Steps to Reproduce (for bugs)
Context
Trying to start apps as configured in globalkeyshosrtcuts.conf
System Information
The text was updated successfully, but these errors were encountered: