renamed base to base_url (fixes #1607)
#1629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mre
reviewed
Feb 10, 2025
mre
reviewed
Feb 10, 2025
| @@ -80,7 +80,7 @@ remap = [ | |||
| ] | |||
|
|
|||
| # Base URL or website root directory to check relative URLs. | |||
| base = "https://example.com" | |||
| base-url = "https://example.com" | |||
There was a problem hiding this comment.
I think we should stick to underscores here.
Suggested change
| base-url = "https://example.com" | |
| base_url = "https://example.com" |
Also check if we have an integration test for that setting already.
mre
reviewed
Feb 10, 2025
mre
reviewed
Feb 10, 2025
| @@ -75,7 +75,7 @@ header = ["name=value", "other=value"] | |||
| remap = ["https://example.com http://example.invalid"] | |||
|
|
|||
| # Base URL or website root directory to check relative URLs. | |||
| base = "https://example.com" | |||
| base-url = "https://example.com" | |||
There was a problem hiding this comment.
Suggested change
| base-url = "https://example.com" | |
| base_url = "https://example.com" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the configuration parameter
basetobase_urlto improve clarity (fixes #1607)