From 44345b1a5fc6286a9303be8c5209aa891489a77b Mon Sep 17 00:00:00 2001 From: glo11372 Date: Thu, 22 Aug 2024 12:56:04 +0530 Subject: [PATCH 1/2] PWA:3279- useScrollLock doesn't have an option to reset on unmount --- packages/peregrine/lib/hooks/useScrollLock.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/peregrine/lib/hooks/useScrollLock.js b/packages/peregrine/lib/hooks/useScrollLock.js index 9423f71c6c..553ddb4285 100644 --- a/packages/peregrine/lib/hooks/useScrollLock.js +++ b/packages/peregrine/lib/hooks/useScrollLock.js @@ -14,5 +14,9 @@ export const useScrollLock = locked => { if (!globalThis.document) return; document.documentElement.dataset.scrollLock = locked || ''; + return () => { + // Logic to set to false on unmount + document.documentElement.dataset.scrollLock = false; + } }, [locked]); }; From 7dcb5826d82df58d318e88d3eb2ca8420ba43e64 Mon Sep 17 00:00:00 2001 From: glo11372 Date: Thu, 22 Aug 2024 13:18:40 +0530 Subject: [PATCH 2/2] PWA:3279: useScrollLock doesn't have an option to reset on unmount --- packages/peregrine/lib/hooks/useScrollLock.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/peregrine/lib/hooks/useScrollLock.js b/packages/peregrine/lib/hooks/useScrollLock.js index 553ddb4285..b436ec0895 100644 --- a/packages/peregrine/lib/hooks/useScrollLock.js +++ b/packages/peregrine/lib/hooks/useScrollLock.js @@ -16,7 +16,7 @@ export const useScrollLock = locked => { document.documentElement.dataset.scrollLock = locked || ''; return () => { // Logic to set to false on unmount - document.documentElement.dataset.scrollLock = false; - } + document.documentElement.dataset.scrollLock = false; + }; }, [locked]); };