-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: /docs/components/number-ticker - StartValue #426
Comments
Can you please assign it to me? |
@PraveenShinde3 - Could you also address the value with commas, or would that be a separate issue? |
I have made a change, so that we can give a custom "start value" For example : in following demo i have set the startValue to "500" and value to "1000" and for decimal the startValue is "3.99" and value to "8.67" Screen.Recording.2024-11-29.205216.mp4 |
@dinbtechit what exactly is the issue with commas? |
Oh I did not realize. The comma's were already taken care of. I am curios what does it look like for large numbers... <NumberTicker startValue={'168,500.10'} value={'170,500.99'} |
this is how it looks as per your given startValue and value the code would be something like this Screen.Recording.2024-11-29.210929.mp4 |
That looks freaking good!! Great job! thanks @PraveenShinde3 |
Hoping this PR gets approved 🤞 |
Hey, we discussed this and decided not to add props like that for now. Instead, we plan to set a custom duration for each |
Is your feature request related to a problem? Please describe.
Always starts from zero. It would be nice if we can provide a starting value
Describe the solution you'd like
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: