Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Runner Warning: SLF4J: Class path contains multiple SLF4J bindings. #649

Closed
TobiasNx opened this issue Nov 14, 2024 · 5 comments · Fixed by #664
Closed

Fix Runner Warning: SLF4J: Class path contains multiple SLF4J bindings. #649

TobiasNx opened this issue Nov 14, 2024 · 5 comments · Fixed by #664
Assignees
Labels
Milestone

Comments

@TobiasNx
Copy link
Contributor

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/tobias/Downloads/metafix-runner-1.1.2/lib/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/tobias/Downloads/metafix-runner-1.1.2/lib/slf4j-simple-1.7.21.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory]

The runner build by core does not have this warning. Not sure if this is related to: metafacture/metafacture-fix#371 (comment)

@TobiasNx
Copy link
Contributor Author

TobiasNx commented Dec 2, 2024

Found at least one source of this warning. The warning is only appearing when the record has a fix method:

NO Warning:

"http://sru.hebis.de/sru/DB=2.1?query=pica.ort+%3D+%22Mainz%22+and+pica.ppn+%3D+%22524204101%22&version=1.1&operation=searchRetrieve&stylesheet=http%3A%2F%2Fsru.hebis.de%2Fsru%2F%3Fxsl%3DsearchRetrieveResponse&recordSchema=marc21&maximumRecords=10&startRecord=1&recordPacking=xml&sortKeys=LST_Y%2Cpica%2C0%2C%2C"
| open-http(accept="application/xml")
| decode-xml
| handle-marcxml
| encode-json(prettyPrinting="true")
| print
;

Shows Warning:

SRUQUERRY = "http://sru.hebis.de/sru/DB=2.1?query=pica.ort+%3D+%22Mainz%22+and+pica.ppn+%3D+%22524204101%22&version=1.1&operation=searchRetrieve&stylesheet=http%3A%2F%2Fsru.hebis.de%2Fsru%2F%3Fxsl%3DsearchRetrieveResponse&recordSchema=marc21&maximumRecords=10&startRecord=1&recordPacking=xml&sortKeys=LST_Y%2Cpica%2C0%2C%2C";

SRUQUERRY
| open-http(accept="application/xml")
| decode-xml
| handle-marcxml
| fix("nothing()")  // DUE TO THE INTRODUCTION OF FIX.
| encode-json(prettyPrinting="true")
| print
;

@TobiasNx
Copy link
Contributor Author

TobiasNx commented Dec 2, 2024

@blackwinter this might be relevant when migrating fix to core:

#577

@TobiasNx
Copy link
Contributor Author

TobiasNx commented Jan 8, 2025

I tried to test it with the new integration of fix into core but it does not work yet: #586 (comment)

@TobiasNx TobiasNx mentioned this issue Jan 27, 2025
37 tasks
@blackwinter blackwinter transferred this issue from metafacture/metafacture-fix Jan 27, 2025
@blackwinter blackwinter added this to the Release 7.0.0 milestone Jan 27, 2025
@blackwinter blackwinter self-assigned this Feb 4, 2025
@blackwinter blackwinter moved this from Backlog to Selected in Metafacture Feb 4, 2025
blackwinter added a commit that referenced this issue Feb 6, 2025
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:.../metafacture-runner/lib/slf4j-simple-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:.../metafacture-runner/lib/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.SimpleLoggerFactory]
@blackwinter
Copy link
Member

Functional review: @TobiasNx
Code review: @dr0i

@blackwinter blackwinter assigned TobiasNx and unassigned blackwinter Feb 6, 2025
@blackwinter blackwinter moved this from Selected to Review in Metafacture Feb 6, 2025
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Feb 6, 2025

Looks good +1

@TobiasNx TobiasNx assigned blackwinter and unassigned TobiasNx Feb 6, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in Metafacture Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants