TestMethod.IsAsync isn't true for ValueTask

[Youssef1313]

testfx/src/Adapter/MSTest.TestAdapter/ObjectModel/TestMethod.cs

Line 57 in 97cb7b4

IsAsync = isAsync;

IsAsync property is public, but we never read it in production code. So the impact here is minimal.

Here, we only handle Task though.

testfx/src/Adapter/MSTest.TestAdapter/Discovery/TypeEnumerator.cs

Line 143 in 97cb7b4

bool isAsync = ReflectHelper.MatchReturnType(method, typeof(Task));

Also, in the following line it's always false:

testfx/src/Adapter/MSTest.TestAdapter/Discovery/AssemblyEnumerator.cs

Line 381 in 97cb7b4

var method = new TestMethod(classFullName, methodName, hierarchy, methodName, classFullName, assemblyLocation, false, null, TestIdGenerationStrategy.FullyQualified);

@Evangelink We should deprecate the public property and remove it completely IMO.

[Evangelink]

Type is already part of the list of deprecated types (public for not well known reason).

[Youssef1313]

Part of this was cleaned up in #4725

We only need to do #4724. Closing this issue then.