Should MSTest.TestAdapter declare MSTest.TestFramework as a dependency?

[Youssef1313]

The nuspec of MSTest.TestAdapter doesn't define MSTest.TestFramework as a dependency, but I don't see any reason why it shouldn't. @Evangelink Do you know if there was a reason in past?

[Evangelink]

I have no idea why the current setup was done as it is. I can't think of a problem doing it right now but let's have it sit for a few days.

[nohwnd]

probably because testadapter already ships the test framework dll so it was not strictly necessary?

[Youssef1313]

@nohwnd It's only shipped in build (not lib) and only for .NET Framework and mainly used for the custom assembly resolver:

testfx/src/Adapter/MSTest.TestAdapter/MSTest.TestAdapter.nuspec

Lines 102 to 111 in 0707b4d

	<!--
	For .NET Framework, when using AppDomains (default) with VSTest, VSTest uses a custom assembly resolver that only
	considers VS folders and MSTest.TestAdapter NuGet folder to look for deps, resulting in TestFramework.dll not
	being found.
	There is no way to fix this issue, but we can work around it by copying the TestFramework.dll to the NuGet
	folder, as it was done before 3.7 cleanup. The original issue mentions MTP which is fixed by not taking explicit
	deps to it in the "engine" project and keep them only under the TestingPlatformAdapter folder.
	See https://github.com/microsoft/testfx/issues/4426
	-->
	<file src="net462\Microsoft.VisualStudio.TestPlatform.TestFramework.dll" target="build\net462\" />

[nohwnd]

okay even though that is a pretty recent change (shipping only for .net framework, before 3.7 it was shipped for all iirc). So not it. :)