Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve VB generated entry point #4815

Closed
Youssef1313 opened this issue Jan 28, 2025 · 0 comments · Fixed by #4884
Closed

Improve VB generated entry point #4815

Youssef1313 opened this issue Jan 28, 2025 · 0 comments · Fixed by #4884
Assignees
@Youssef1313
Labels
Area: Testing Platform MSBuild Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library In-PR
Milestone
MSTest 3.8 / Plat...

Comments

@Youssef1313
Copy link
Member

Unrelated to your changes, but this potentially doesn't match the behavior of C#. It may be worth updating this to GetAwaiter().GetResult() instead to match C#. And maybe have some test (at least manual) to verify that.

Originally posted by @Youssef1313 in #4814 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
Area: Testing Platform MSBuild Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library In-PR
Projects
None yet
Milestone
MSTest 3.8 / Platform 1.6
Development

Successfully merging a pull request may close this issue.

Cleanup VB entrypoint Youssef1313/testfx
1 participant
@Youssef1313