Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support !: commit syntax for breaking changes #26

Closed
mikeal opened this issue May 11, 2020 · 4 comments · Fixed by #39
Closed

Support !: commit syntax for breaking changes #26

mikeal opened this issue May 11, 2020 · 4 comments · Fixed by #39
Labels
good first issue Good for newcomers

Comments

@mikeal
Copy link
Owner

mikeal commented May 11, 2020

The current rules only support the old “BREAKING” message. Conventional commits added a “fix!:” and “feat!:” for signaling breaking changes. We should just parse for “!:” for a major version bump.

@mikeal mikeal added the good first issue Good for newcomers label Jun 11, 2020
@mikeal mikeal pinned this issue Jun 11, 2020
@honzabilek4
Copy link
Contributor

Hello @mikeal,
not everyone uses conventional commits. Can we make these keywords configurable, so everyone can adjust it to their liking?
I would like to submit a PR for that.

@mikeal
Copy link
Owner Author

mikeal commented Oct 5, 2020

i’d like the interface to be stable and consistent. it’s not that i’m adamant that people use conventional commits, i just don’t think this will be a very maintainable project if we start allowing that level of customization. i feel the same way about configuring whether or not every commit releases or just some, the consistency is part of the interface and keeps the usage simple.

there’s plenty of other projects for doing releases though, many of which are highly configurable like https://github.com/googleapis/release-please

@honzabilek4
Copy link
Contributor

honzabilek4 commented Oct 5, 2020

Okay, I'll use some other action instead.

@Sergio6690
Copy link

  1. zz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants