Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification for theme settings #613

Open
Natejoestev opened this issue Jan 28, 2025 · 0 comments
Open

Clarification for theme settings #613

Natejoestev opened this issue Jan 28, 2025 · 0 comments

Comments

@Natejoestev
Copy link

I recently tried tweaking my Shell theme to just the way i want it, and i noticed that the documentation is very lax for expected values.
I would also like to see default values, since adjusting the default to slightly above or below is difficult when you don't know what the default is.
it also seems that as you read, there are different thought processes behind the docs.

I would like to see it standardized, with more information.

repeated structure

for example, for coloring, padding, and margin:

margin {
  left = 0
  right = 0
  top = 0
  bottom = 0
}

it would be nice to see, a simpler structure

margin = [1,3, 5,10]

there is documentation already showing this will map to [left,right, top,bottom].

defaults

it would also be nice if these structures had defaults

margin = [2,2, 5,5]

this way, if i want to make my item wider, but same height i can go [4,4, 5,5]

Booleans

but there are other things, like different ways of representing Booleans.

dark = true or false
...
enabled = boolean value
...
italic = 0

here it would be nice to just say

dark = true #shows default value, and is a boolean
enabled = false #dissabled by default
italic = false #...

and in another spot, you can clarify, a boolean can be 1/0 true/false, so the user tells clearly.

description

some settings, it is quite obvious of what the value means.
border.size, the amount of pixels wide the border is.
some do not. font.italic = 0 is this a boolean or a lean factor; if so, 0-90°, 0-100?

I feel like adding these would make Shell a lot smoother to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant