Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of UIColor.Photon.White100 #24460

Open
lmarceau opened this issue Jan 30, 2025 · 0 comments
Open

Replace usage of UIColor.Photon.White100 #24460

lmarceau opened this issue Jan 30, 2025 · 0 comments
Labels
Contributor OK This is a good issue for contributors interested in helping the project Theming System Relates to removing the legacy theme, or improving theming related problems

Comments

@lmarceau
Copy link
Contributor

lmarceau commented Jan 30, 2025

📄 Context

We have deprecated colors in our app under photon-colors.swift we shouldn't be using anymore. I am creating some tasks so we remove them one by one to ensure we make small PRs and evaluate colors usage per their context.

✏ Requirements

  1. GradientProgressBar and TopTabFader both uses  UIColor.Photon.White100. Let's replace those with UIColor.white. This will avoid a redesign and remove the deprecated color system.
  2. Put screenshots of before/after in your PR in light and dark mode of the affected area. There should be no visual changes.

Note; if UIColor.Photon.White100 isn't used anymore, you can remove it from the photon-colors.swift file

ℹ️ Reference Person

@lmarceau

┆Issue is synchronized with this Jira Task

@lmarceau lmarceau added Contributor OK This is a good issue for contributors interested in helping the project Theming System Relates to removing the legacy theme, or improving theming related problems labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor OK This is a good issue for contributors interested in helping the project Theming System Relates to removing the legacy theme, or improving theming related problems
Projects
None yet
Development

No branches or pull requests

1 participant