-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Release with compatibility Chart.js v3 #28
Comments
I will update the build system, workflows and documentation, add TypeScript support, improve ES module support, then release v1 😉 |
When we will can get the new release for chartjs v3? |
What is the latest Chart.js compatible version? |
I was playing a bit with colorscheme v0.4.0 + Chart.js, and until v2.9.4 the plugin seems to work, but for newer versions (+3.0.2), colorscheme is broken with the following error:
|
@nagix Any idea of a release date for v1? |
Hello! |
Hi. Uncaught TypeError: Chart.defaults.global is undefined |
I encountered the same same issues. I was able to get it working with chart.js 3.5.1 by applying the above patch, but also: Line 1075 - beforeUpdate: added following new line to get plugin options from chart object (as they were not present in argument options): |
Also replace |
I think this may help resolve ChartJs 3 compatibility: #30, check it out and make sure it's working! |
I think there is one more problem with the typ 'bar'. in beforeUpdate the forEach which should set scheme colors, it set only the first color |
Colorschemes plugin is not compattible with V3. Issue about it: nagix/chartjs-plugin-colorschemes#28 Open PR for improving V3 compatability: nagix/chartjs-plugin-colorschemes#30
Colorschemes plugin is not compattible with V3. Issue about it: nagix/chartjs-plugin-colorschemes#28 Open PR for improving V3 compatability: nagix/chartjs-plugin-colorschemes#30
@nagix do you have any idea when the next release can be released with compatibility with chart.js 3.X.X ? Thanks |
Sorry for insisting, @nagix do you know when you have time for a new release? 😄 |
Hello |
"I will update the build system, workflows and documentation, add TypeScript support, improve ES module support, then release v1" |
@nagix Any idea of a release date for v1? Supporting Chart.js V3 becomes important for many projects and avoid using this plugin for compatibility problem is wasted your work, |
just a 👍 for your great work combined with a tiny please release V3 support |
In issue #33 jayantbh has written
Indeed, this fork works with ChartJS 3.x, but has another bug. If I use this ChartJS config {
type: 'bar',
data: {
labels: ['diagramLabel'],
datasets: [{
label: 'dataLabel',
data: [1],
backgroundColor: '#00FF00'
}]
},
options: {
plugins: {
colorschemes: {
scheme: 'brewer.YlGn3'
}
}
}
} the resulting data bar has not the configured background-color Can someone reproduce and confirm it? In ChartJS 2.x with the unpatched colorscheme-plugin it works. |
It's been nearly 2 years since the last post in this Issue, and sadly still no new official release of this great plugin with ChartJS 3 support on the horizon 😞 @nagix is there any chance for that to ever happen ? If you don't have time or motivation to continue maintaining this that's perfectly fine and understandable (and thank you for your work !), but in that case maybe you would consider granting write access to this repo to one or more people so it can be kept alive, or transfer ownership to someone who is willing to take over its maintenance ? I noticed several forks which claim support for v3 but they are diverging so I'm not sure which one I should use (I need CDN too)... It would be awesome if they could be unified @MaximBelov @zsu @m08pvv |
@dregad Install
Let me know about any issues Changes |
Thank you, I upgraded my code to use chart.js 3.9.1 + hw-chartjs-plugin-colorschemes 0.5.4, and it seems to work fine overall. I just have a regression compared to my legacy 2.9.4 / 0.4.0 code, but to avoid highjacking this thread and for lack of a better place to report issues, I have opened #41: custom backgroundColor on a pie chart's datasets are ignored. |
Use version 0.6.1+ for charts.js v4+ |
Thank you @MaximBelov ❤️ ! May I suggest to create Git tags at NOTE: v0.6.0 tag at bea237c is incorrect, that's actually v0.6.1... v0.6.0 should be fb1e919. the Release is wrong, too. It would be useful as well, to have Releases with a brief description indicating the change in chart.js support (v0.5.4 for 3.x, v0.6.1 for 4.x). Thanks again ! |
No problems |
After merging #26 it would be nice to see it as npm package's release :)
The text was updated successfully, but these errors were encountered: