Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not support firefox #2

Open
3 tasks done
Jayy001 opened this issue Nov 25, 2022 · 5 comments · May be fixed by #4
Open
3 tasks done

Does not support firefox #2

Jayy001 opened this issue Nov 25, 2022 · 5 comments · May be fixed by #4

Comments

@Jayy001
Copy link

Jayy001 commented Nov 25, 2022 •
edited
Loading

Describe the bug

When trying to install the extension from Firefox, it gives an error that is is corrupt and so cannot install it. I've ran the following commands:

git clone https://github.com/ndom91/briefkasten-extension
cd briefkasten-extension
npm install
npm run build
cd dist
zip -r -FS ../my-extension.zip *

And then gone to the extension manager => install from file => my-extension.zip

From debugging, it seems that it's an invalid manifest version, so I changed that to 2 and then tried it again. Now it gives the following error:

Extension is invalid

Reading manifest: Error processing background: Value must either: contain the required "page" property, contain the required "scripts" property, or not contain an unexpected "type" property

Reproduction

View above

System Info

System:
    OS: Linux 6.0 Pop!_OS 22.04 LTS
    CPU: (6) x64 Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
    Memory: 10.54 GB / 15.56 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 12.22.9 - /usr/bin/node
    npm: 8.5.1 - /usr/bin/npm
  Browsers:
    Firefox: 107.0

Used Package Manager

npm

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@zackchadwick
Copy link

zackchadwick commented Mar 14, 2023 •
edited
Loading

Currently encountering this bug with Firefox version 111.

##Edit

This appears to be an issue with how Mozilla is choosing to implement Manifest V3. Ref: https://stackoverflow.com/questions/75043889/manifest-v3-background-scripts-service-worker-on-firefox

Editing the manifest.json file from:

  "background": {
    "service_worker": "background.js",
    "type": "module"
  },

To:

  "background": {
    "scripts": ["background.js"]
  },

Allowed me to successfully install the addon and it appears to be working correctly.

@mpldr
Copy link

mpldr commented May 3, 2023 •
edited
Loading

I have successfully compiled it and submitted it to Mozilla for signing. After it's been signed, I will post it here so others can just install it right away.

@zackchadwick
Copy link

I have successfully compiled it and submitted it to Mozilla for signing. After it's been signed, I will post it here so others can just install it right away.

Were you able to get the extension signed?

@mpldr
Copy link

mpldr commented Jul 14, 2023 via email

@zerebos zerebos linked a pull request Aug 29, 2023 that will close this issue
Open
@zerebos
Copy link

zerebos commented Aug 30, 2023

For those waiting, I was able to get Mozilla's approval.

You can download the addon here: https://addons.mozilla.org/addon/briefkasten-unofficial/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(firefox): add firefox build script zerebos/briefkasten-extension
4 participants
@zerebos @mpldr @Jayy001 @zackchadwick