From af76bf7354360c7e0a00ce680150c5b86f82af39 Mon Sep 17 00:00:00 2001 From: Pablo Carranza Date: Sat, 11 Jan 2025 15:47:59 +0100 Subject: [PATCH] Log docker pull failure to the raw_output logger so it reaches gitea --- pkg/container/docker_pull.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/container/docker_pull.go b/pkg/container/docker_pull.go index 65b930eefbc..1ef95372d17 100644 --- a/pkg/container/docker_pull.go +++ b/pkg/container/docker_pull.go @@ -70,6 +70,11 @@ func NewDockerPullExecutor(input NewDockerPullExecutorInput) common.Executor { } return err } + + // Log the error to the task output, otherwise it fails silently and makes everyone sad + // rawOutput is how to reach either gitea runner output, or the terminal output itself + common.Logger(ctx).WithField("raw_output", true).Errorf("Failed to pull docker image %s: %s", imageRef, err) + return nil } }