Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_metrics_normal_work is flaky #10461

Closed
erikgrinaker opened this issue Jan 21, 2025 · 0 comments · Fixed by #10522
Closed

test_metrics_normal_work is flaky #10461

erikgrinaker opened this issue Jan 21, 2025 · 0 comments · Fixed by #10522
Assignees
@VladLazar
Labels
a/test/flaky Area: related to flaky tests c/storage Component: storage t/bug Issue Type: Bug

Comments

@erikgrinaker
Copy link
Contributor 

test_runner/regress/test_tenants.py:206: in test_metrics_normal_work
    assert total_bytes > 0
E   assert 0 > 0

https://neonprod.grafana.net/d/fddp4rvg7k2dcf/regression-test-failures?orgId=1&var-test_name=test_metrics_normal_work&from=now-7d&to=now&timezone=utc&var-restrict=true&var-max_count=100&var-reference=$__all&var-ignore_reference=refs%2Fpull%2F0000%2Fmerge
@erikgrinaker erikgrinaker added a/test/flaky Area: related to flaky tests c/storage Component: storage t/bug Issue Type: Bug labels Jan 21, 2025
@VladLazar VladLazar mentioned this issue Jan 27, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 28, 2025
@VladLazar
pageserver: use PS node id for SK appname (#10522)
62a717a 
## Problem

This one is fairly embarrassing. Safekeeper node id was used in the
pageserver application name
when connecting to safekeepers.

## Summary of changes

Use the right node id.

Closes #10461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VladLazar VladLazar

Labels
a/test/flaky Area: related to flaky tests c/storage Component: storage t/bug Issue Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pageserver: use PS node id for SK appname neondatabase/neon
2 participants
@erikgrinaker @VladLazar