Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branching feature should work with NetBox database objects deployed under user defined schema (not public). #181

Open
sawantmg opened this issue Nov 19, 2024 · 2 comments
Labels
status: revisions needed This issue requires additional information to be actionable type: feature A new feature or functionality

Comments

@sawantmg
Copy link

Plugin Version

netbox-branching Release v0.5.2

Proposed functionality

With the branching feature, when a local branch is activated, the search_path option in the connection string is updated to include the schema associated with the 'activated branch' as the first choice, followed by the 'public' schema. However, this doesn't well work if the NetBox database objects are deployed under the 'public' schema. Access to any object that is not part of the 'activate branch' fails as that object cannot be found under the 'public' schema either.

Please update the functionality such that the branching feature works with an user defined schema.

Use case

With managed databases, users may not be able to deploy application specific database objects to public schema. Therefore, it is important for NetBox branching feature to support user defined schemas.

External dependencies

No response

@sawantmg sawantmg added the type: feature A new feature or functionality label Nov 19, 2024
@jeremystretch
Copy link
Contributor

@sawantmg I'm not sure I follow:

However, this doesn't well work if the NetBox database objects are deployed under the 'public' schema.

Did you mean objects that are not in the public schema? Is the proposal here just to allow the NetBox administrator to configure the name of the default PostgreSQL schema?

@jeremystretch jeremystretch added the status: revisions needed This issue requires additional information to be actionable label Jan 24, 2025
@sawantmg
Copy link
Author

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: revisions needed This issue requires additional information to be actionable type: feature A new feature or functionality
Projects
None yet
Development

No branches or pull requests

2 participants