Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sure what +389 KB in auto upload page means #14428

Open
bilogic opened this issue Jan 17, 2025 · 3 comments
Open

Not sure what +389 KB in auto upload page means #14428

bilogic opened this issue Jan 17, 2025 · 3 comments
Assignees
Labels
enhancement feature: auto upload papercut Annoying recurring issue with possibly simple fix

Comments

@bilogic
Copy link

bilogic commented Jan 17, 2025

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Image
What does this screenshot mean? Why doesn't nextcloud android app want to upload the +389 KB folder?

Describe the solution you'd like
Remove the folder and write Empty

If the app has uploaded all files (images, documents and everything else), why still show a folder saying +389 KB? Whatever shown should be relatively self explanatory with regards to the page, in this case Auto upload. My most direct interpretation is there are +389 KB worth of data in a folder that was not uploaded.... and the question is why? bug?

Describe alternatives you've considered
N/A

Additional context
N/A

@joshtrichards
Copy link
Member

It's placeholder. I believe it just gets displayed in some situations until things are fully loaded:

<string name="placeholder_sentence">This is a placeholder</string>
<string name="placeholder_filename">placeholder.txt</string>
<string name="placeholder_fileSize">389 KB</string>
<string name="placeholder_timestamp">2012/05/18 12:23 PM</string>
<string name="placeholder_media_time">12:23:45</string>

It may be possible to make it clearer. Some of the others are more obvious.

I have it pop up on one (only one; not sure why) of my many listed folders. It goes away after scrolling down than back up. So there may be some room for optimization as well (i.e. something else may be going on in some cases that keeps the placeholder active for longer than intended).

@bilogic
Copy link
Author

bilogic commented Jan 19, 2025

This placeholder feature has never ever gone away for an empty folder, be it production, dev or QA and an extremely misleading one I might add. This is a display (not input), thus placeholders should indicate things are still loading and not present some fake value, i.e. +389 KB

My folders are all empty as I selected the delete option, so this placeholder should have disappeared, not stayed on. I consider this feature broken.

A possible fix is

  1. Placeholder should say Loading... or Scanning... or just ... if animation is not possible
  2. If folder is empty, placeholder should be replaced with No files here, like other parts of the Android app
  3. If folder is not empty, then placeholder is replaced by thumbnails of the files in it
nextcloud-bug.mp4

@joshtrichards joshtrichards added the papercut Annoying recurring issue with possibly simple fix label Jan 19, 2025
@alperozturk96 alperozturk96 self-assigned this Jan 20, 2025
@alperozturk96
Copy link
Collaborator

Thank you for the report. Great findings. Suggestion make sense to me as well.

@tobiasKaminsky What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature: auto upload papercut Annoying recurring issue with possibly simple fix
Projects
None yet
Development

No branches or pull requests

3 participants