Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #6

Open
chris48s opened this issue Jan 27, 2021 · 0 comments
Open

Improve test coverage #6

chris48s opened this issue Jan 27, 2021 · 0 comments

Comments

@chris48s
Copy link
Member

Starting here:

"""
def test_form_submit_success_xml_file_from_url(
self, app, monkeypatch, tmpdir, ckan_config
):
_patch_storage_path(monkeypatch, tmpdir, ckan_config)
# TODO: test importing from a URL, mock the HTTP requests with responses
def test_form_submit_success_xml_and_rdf_files_from_urls(
self, app, monkeypatch, tmpdir, ckan_config
):
_patch_storage_path(monkeypatch, tmpdir, ckan_config)
# TODO: test importing from URLs, mock the HTTP requests with responses
"""

We should also have some more robust tests for the importer/metadata modules. At the moment all of our tests are processing one example file which doesn't really exercise the full range of execution paths there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant