-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a circular buffer data structure #2
Comments
I have a queue implementation backed by a ring-buffer at https://github.com/eapache/queue - it ends up being much faster because it causes less garbage for the garbage collector. |
Looks neat! A few questions:
Let me know what you think :) |
I am open to the idea, though I will continue to maintain the existing one. I use it in https://github.com/eapache/channels/ where the lack of locking is a fairly significant performance improvement (in fact I originally wrote it embedded in that package, and factored it out later). |
Okay, fair enough. So is it okay for me to adapt your structure in https://github.com/oleiade/lane while keeping your license? Let me open a specific branch and pull request, and give me you're impressions. |
Go right ahead, the license is MIT which is quite permissive. |
I also have the following package you can use https://github.com/fzakaria/circularfifoqueue I was thinking if you made |
http://en.wikipedia.org/wiki/Circular_buffer
The text was updated successfully, but these errors were encountered: