Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

Allow climate device hvac_modes default override #33

Open
maforshaw opened this issue Sep 13, 2020 · 2 comments
Open

Allow climate device hvac_modes default override #33

maforshaw opened this issue Sep 13, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@maforshaw
Copy link

If the integration cannot determine the hvac_modes of a climate device from the API, it defaults to: off, heat_cool

        if modes is None:
            if HVAC_MODE_HEAT_COOL not in self.operations:
                self.operations.append(HVAC_MODE_HEAT_COOL)
            return

For my device, a heater, that's actually wrong and it should be HVAC_MODE_HEAT. It would therefore be good if the default value could be set via the config rather than hard-coded to HVAC_MODE_HEAT_COOL.

@ollo69
Copy link
Owner

ollo69 commented Sep 13, 2020

I used HVAC_MODE_HEAT_COOL because is generic, anyway I will keep in consideration your request for future releases.

@ollo69 ollo69 added the enhancement New feature or request label Sep 13, 2020
@maforshaw
Copy link
Author

Thanks, it's a minor detail. I noticed it because the Thermostat Card displays the wrong icon since it uses hvac_modes to determine what to use. Also, the documentation for Climate says you must not set Temperature in climate.set_temperature if hvac_mode is heat_cool, which is actually incorrect in my case because that's all you can set.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants