Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on Fp6::invert_x #2

Open
unbalancedparentheses opened this issue Aug 25, 2023 · 1 comment
Open

Error on Fp6::invert_x #2

unbalancedparentheses opened this issue Aug 25, 2023 · 1 comment

Comments

@unbalancedparentheses
Copy link

Line of the bug: https://github.com/onurinanc/noir-bn254/blob/main/src/bn254/fp6.nr#L215

There's an error in the algorithm causing the function to fail when it is supposed to work.

Step 9 is wrong in the paper. Instead of $c_{2} = t_{1} \cdot t_{4}$ it should be $c_{2} = t_{1} - t_{4}$

@unbalancedparentheses
Copy link
Author

We didn't think it enough but we think there might be a way to exploit it. We doubled checked with others that this was not used in prod before creating the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant