Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TE-11.21, TE-11.31, TE-3.31 : README updated with new VRF selection policy but the test doesnt have the validation based on it #3619

Closed
bkreddy143 opened this issue Dec 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@bkreddy143
Copy link
Contributor

TE-11.21: Backup NHG: Multiple NH with PBF
TE-11.31: Backup NHG: Actions with PBF
TE-3.31: Hierarchical weight resolution with PBF
Above tests are cloned from POPGate project and README updated with following DCGate requirements but README doesnt cover the usage of the policies and test based on that. Test procedure doesn't capture the usage of vrf_selection_policy_w policy and its action.

Add an empty decap VRF, DECAP_TE_VRF.
Add 4 empty encap VRFs, ENCAP_TE_VRF_A, ENCAP_TE_VRF_B, ENCAP_TE_VRF_C and ENCAP_TE_VRF_D.
Replace the existing VRF selection policy with vrf_selection_policy_w as in #2217

Could you please confirm if that is expected test? If yes request to update the script to add all required VRF like ENCAP_TE_VRF_A, ENCAP_TE_VRF_B, ENCAP_TE_VRF_C and ENCAP_TE_VRF_D and DECAP_TE_VRF . Currently Test is failing as these VRFs are not created but tried to used in vrf_selection_policy_w.

@bkreddy143 bkreddy143 added the bug Something isn't working label Dec 4, 2024
@cfernanz cfernanz removed their assignment Dec 16, 2024
@nflath
Copy link
Contributor

nflath commented Jan 20, 2025

I'm a bit confused on what the ask is here?

@bkreddy143
Copy link
Contributor Author

@nflath , when i looked it i thought these tests are meant to cover more of policy functionality but looks like there are other tests got added for to test vrf_policy so we can ignore this ticket for now. Regarding the missing VRFs it was failing due to interface missing in default VRF and we creating PR for the same .

I can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

4 participants