[PRE REVIEW]: IAMReX: an adaptive framework for the multiphase flow and fluid-particle interaction problems

[editorialbot]

Submitting author: @ruohai0925 (Yadong Zeng)
Repository: https://github.com/ruohai0925/IAMReX.git
Branch with paper.md (empty if default branch): development
Version: v1.0.0
Editor: Pending
Reviewers: Pending
Managing EiC: Arfon Smith

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/811afe9031d46cb321bc2345faad06a9"><img src="https://joss.theoj.org/papers/811afe9031d46cb321bc2345faad06a9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/811afe9031d46cb321bc2345faad06a9/status.svg)](https://joss.theoj.org/papers/811afe9031d46cb321bc2345faad06a9)

Author instructions

Thanks for submitting your paper to JOSS @ruohai0925. Currently, there isn't a JOSS editor assigned to your paper.

@ruohai0925 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1006/jcph.1998.5890 is OK
- 10.1016/j.jcp.2021.110740 is OK
- 10.1016/j.jcp.2023.111971 is OK
- 10.1063/5.0236509 is OK
- 10.21105/joss.01370 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

[arfon]

@kyleniemeyer – noting that this is a resubmission of #7582

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.98  T=0.13 s (1319.3 files/s, 305078.2 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                              35           3580           3760          18103
C/C++ Header                     32            633            921           2932
reStructuredText                 21           1159            241           2387
Python                           10            304            445           1114
YAML                             12             87             22            665
make                             31            343            157            569
Markdown                          7            166              2            469
INI                               2             54              0            364
TeX                               4             44              2            362
Bourne Again Shell                6            102            188            276
Fortran 77                        4             60             86            245
Text                              3             25              0            194
Bourne Shell                      5             16              7             87
Fortran 90                        1              4              9             43
CSS                               1              1              1              8
--------------------------------------------------------------------------------
SUM:                            174           6578           5841          27818
--------------------------------------------------------------------------------

Commit count by author:

   821	cgilet
   786	lijewski
   280	Michele Rosso
   264	almgren
   243	Weiqun Zhang
   211	car
   167	Emmanuel Motheau
   120	Marc Day
   114	Lucas Esclapez
   100	marc
    97	yzeng
    96	Andy Nonaka
    76	Ann Almgren
    75	sstanley
    60	Emmanuel
    57	ajnonaka
    54	aaspden
    54	propp
    51	S-Explorer
    36	ruohai0925
    31	vince
    27	jbb
    25	knutsvk
    17	FSI-in
    12	xinfeng
    11	Relax-in
    10	Candace Gilet
     8	Ethan Van Andel
     8	Matthew Emmett
     6	LIU
     5	[email protected]
     5	yzeng_altair
     4	Andrew Myers
     4	Collectors
     3	Valentina Ricchiuti
     3	Wileam Phan
     3	emotheau
     2	Kan Bok-Hua
     2	Landon Owen
     2	Max Katz
     2	hs
     1	Anne Felden
     1	AoooE
     1	Burlen Loring
     1	Damian
     1	Damian Coveney
     1	Erik
     1	Francois Hamon
     1	John Bell
     1	Jon Rood
     1	Mike Lijewski
     1	Oscar Antepara
     1	OscarAntepara
     1	Regression Tester account
     1	Vincent Beckner
     1	Yiliang Wang
     1	aja
     1	gilet
     1	mzingale
     1	sepp
     1	wyc

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 829

🔴 Failed to discover a Statement of need section in paper

[editorialbot]

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[editorialbot]

Five most similar historical JOSS papers:

MAESTROeX: A Massively Parallel Low Mach Number Astrophysical Solver
Submitting author: @doreenfan
Handling editor: @arfon (Active)
Reviewers: @tukss, @pgrete
Similarity score: 0.7319

PeleLMeX: an AMR Low Mach Number Reactive Flow Simulation Code without level sub-cycling
Submitting author: @esclapez
Handling editor: @kyleniemeyer (Active)
Reviewers: @mameehan5, @xzz105, @muellerm-pu
Similarity score: 0.7268

chombo-discharge: An AMR code for gas discharge simulations in complex geometries
Submitting author: @rmrsk
Handling editor: @ppxasjsm (Active)
Reviewers: @jannisteunissen, @michellegurevich
Similarity score: 0.7162

OpenCMP: An Open-Source Computational Multiphysics Package
Submitting author: @nasserma
Handling editor: @lucydot (Active)
Reviewers: @bonh, @WilkAndy
Similarity score: 0.7054

ERF: Energy Research and Forecasting
Submitting author: @asalmgren
Handling editor: @kthyng (Active)
Reviewers: @pratikvn, @rafmudaf
Similarity score: 0.7012

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[ruohai0925]

@kyleniemeyer – noting that this is a resubmission of #7582

Hi @arfon @kyleniemeyer, thanks for taking care of that. For potential reviewers, I would recommend the GitHub user YqWangcfd, FR13ndSDP, xcheng86, jannisteunissen, and rafmudaf. They have been working on the AMReX-based app for several years. Let me know if that works.

[ruohai0925]

Paper file info:

📄 Wordcount for paper.md is 829

🔴 Failed to discover a Statement of need section in paper

How to handle this failed to discover a "Statement of need" issue. I think this issue also appeared at the first submission. After that, I added some paragraphs in the paper to emphasize the statement of need about our work.

[kyleniemeyer]

@ruohai0925 JOSS requires an explicit section with the name "Statement of Need" - so please do add that to your paper (and perhaps move those paragraphs into it)

[ruohai0925]

@kyleniemeyer Thanks a lot! I added the "Statement of need" section.

[kyleniemeyer]

@editorialbot generate pdf

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[editorialbot]

Five most similar historical JOSS papers:

MAESTROeX: A Massively Parallel Low Mach Number Astrophysical Solver
Submitting author: @doreenfan
Handling editor: @arfon (Active)
Reviewers: @tukss, @pgrete
Similarity score: 0.7299

PeleLMeX: an AMR Low Mach Number Reactive Flow Simulation Code without level sub-cycling
Submitting author: @esclapez
Handling editor: @kyleniemeyer (Active)
Reviewers: @mameehan5, @xzz105, @muellerm-pu
Similarity score: 0.7238

OpenCMP: An Open-Source Computational Multiphysics Package
Submitting author: @nasserma
Handling editor: @lucydot (Active)
Reviewers: @bonh, @WilkAndy
Similarity score: 0.7167

chombo-discharge: An AMR code for gas discharge simulations in complex geometries
Submitting author: @rmrsk
Handling editor: @ppxasjsm (Active)
Reviewers: @jannisteunissen, @michellegurevich
Similarity score: 0.7128

RHEA: an open-source Reproducible Hybrid-architecture flow solver Engineered for Academia
Submitting author: @lluisjofre
Handling editor: @diehlpk (Active)
Reviewers: @ctdegroot, @thomasgillis
Similarity score: 0.7045

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[kyleniemeyer]

OK, thanks @ruohai0925. Unfortunately, we do not have an editor available to handle this right now, so I have to put it on our waitlist until someone becomes free.

In the meantime, one thing to consider: I see a Test directory, but it appears to only mention a suite of regression tests for IAMR, and not IAMReX. JOSS does require that software submissions have a test suite, so this is something that reviewers will be looking for (and IAMReX would need distinct tests, even if they build on what was sufficient for IAMR, I assume.)

[ruohai0925]

@kyleniemeyer Thanks for the suggestions! I will work with the coauthors to make a distinct test suit for IAMReX.