Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: EMGFlow: A Python package for pre-processing and feature extraction of electromyographic signals #7696

Open
editorialbot opened this issue Jan 18, 2025 · 7 comments
Assignees
Labels
Python review TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @WiIIson (D. William Lawrence Conley)
Repository: https://github.com/WiIIson/EMGFlow-Python-Package
Branch with paper.md (empty if default branch):
Version: v1.0.16
Editor: @faroit
Reviewers: @wbaccinelli, @samiralavi
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d63dac2393dede4adb8ebc6910f3b65c"><img src="https://joss.theoj.org/papers/d63dac2393dede4adb8ebc6910f3b65c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d63dac2393dede4adb8ebc6910f3b65c/status.svg)](https://joss.theoj.org/papers/d63dac2393dede4adb8ebc6910f3b65c)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@wbaccinelli & @samiralavi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @faroit know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@wbaccinelli, please create your checklist typing: @editorialbot generate my checklist

@samiralavi, please create your checklist typing: @editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/TAFFC.2015.2392932 is OK
- 10.1016/j.softx.2024.101712 is OK
- 10.1109/ACCESS.2022.3146729 is OK
- 10.1109/TAFFC.2015.2457417 is OK
- 10.1111/j.1469-8986.1986.tb00676.x is OK
- 10.5281/zenodo.6403363 is OK
- 10.1007/s12253-019-00668-3 is OK
- 10.1109/T-AFFC.2011.15 is OK
- 10.3389/fpsyg.2016.00780 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.3389/fneur.2020.576729 is OK
- 10.1038/s41598-021-85163-z is OK
- 10.1145/3242969.3242985 is OK
- 10.1038/s41597-019-0209-0 is OK
- 10.3389/fict.2017.00001 is OK
- 10.1044/1092-4388(2011/11-0214) is OK
- 10.1073/pnas.0908994106 is OK
- 10.1186/1743-0003-7-21 is OK
- 10.1109/SSCI.2016.7849931 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: A practicum on the use of sEMG signals in movement...
- No DOI given, and none found for title: An electromyographic index for localized muscle fa...
- No DOI given, and none found for title: A novel feature extraction for robust EMG pattern ...
- No DOI given, and none found for title: PhysioData Toolbox

❌ MISSING DOIs

- 10.1152/jappl.1983.54.1.51 may be a valid DOI for title: Changes in electromyogram power spectra of facial ...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.04 s (846.2 files/s, 190262.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                        11           1210              0           2176
Python                          11            668           1550           1249
TeX                              1             24              0            342
YAML                             2             17              0             92
TOML                             1              2              0             28
JSON                             4              0              0             24
INI                              1              3              0             19
Text                             2              0              0             16
-------------------------------------------------------------------------------
SUM:                            33           1924           1550           3946
-------------------------------------------------------------------------------

Commit count by author:

   143	WiIIson

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1653

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@faroit
Copy link

faroit commented Jan 18, 2025

@wbaccinelli @samiralavi 👋 Hi and thanks again for agreeing to review this paper. You can start the review now. Please use issues in the package repository to discuss with @WiIIson about the submission and refer to these issues here to keep this thread lightweight.

If you have any further questions, let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python review TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

2 participants