Add versioning #44
Merged
Add versioning #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #43 (comment) |
dovholuknf
reviewed
Sep 13, 2024
zssh/zssh/main.go
Outdated
| ) | ||
|
|
||
| var rootCmd = &cobra.Command{ | ||
| Use: fmt.Sprintf("%s %s <remoteUsername>@<targetIdentity>", ExpectedServiceAndExeName, flags.ServiceName), | ||
| Short: "Z(iti)ssh, Carb-loaded ssh performs faster and stronger than ssh", | ||
| Long: "Z(iti)ssh is a version of ssh that utilizes a ziti network to provide a faster and more secure remote connection. A ziti connection must be established before use", | ||
| Version: fmt.Sprintf("%s (commit: %s, built: %s)", version, commit, date), |
There was a problem hiding this comment.
can you update zscp, too, please? i'm not a fan of all the additional output for the commit hash and date. i'd rather just see the version number.
Can you make the output look like:
1.0.9B (built:2024-09-13T19:26:54Z)
or with the hash use the short hash:
1.0.9B (built:2024-09-13T19:26:54Z hash:e9df4770)
There was a problem hiding this comment.
i see you did zscp too - thx
dovholuknf
reviewed
Sep 13, 2024
dovholuknf
approved these changes
Sep 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to output a version