Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for product-dependencies (pdeps) embedded in jar manifests #71

Open
iamdanfox opened this issue Nov 30, 2020 · 2 comments
Open

Comments

@iamdanfox
Copy link
Contributor

I'm pretty sure if you have a classpath which contains a few jars, each with their own 'product-dependency' info embedded in their manifest, applying the shadow-jar plugin won't correctly preserve this info

@jeremyk-91
Copy link
Contributor

jeremyk-91 commented Dec 1, 2020

I noticed that when I run the publish task on atlasdb proxy I get

  - Variant shadowRuntimeElements:
      -  contains dependencies that cannot be represented in a published pom file.
          - my-product:1.76.1-1-g2412483 declared with Gradle attributes

@iamdanfox
Copy link
Contributor Author

I think the bug is valid, but that particular warning you're seeing is actually something different (and harmless) - there's a concept of gradle 'attributes' which the plugin uses internally, and effectively get thrown away when you publish to a normal maven repo with a pom. Gradle invented their own replacement for pom files called .module files which can represent these fancy attributes, but we've chosen to turn them off because they didn't play nicely with GCV (and also keep life simple)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants