Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuonglm/issue 1 #2

Merged
merged 3 commits into from
Dec 23, 2019
Merged

Cuonglm/issue 1 #2

merged 3 commits into from
Dec 23, 2019

Conversation

cuonglm
Copy link
Collaborator

@cuonglm cuonglm commented Dec 23, 2019

Use afero for abstract filesystem layer.

Updates #1

@cuonglm cuonglm requested a review from patcito December 23, 2019 05:25
@cuonglm
Copy link
Collaborator Author

cuonglm commented Dec 23, 2019

@patcito seems we need to setup CI for the repo?

@patcito patcito merged commit 45f4aff into patcito:master Dec 23, 2019
@patcito
Copy link
Owner

patcito commented Dec 23, 2019

Thanks I've set up the CI on https://cloud.drone.io/patcito/gitea

@patcito
Copy link
Owner

patcito commented Dec 23, 2019

Do you have access to CI? it seems to be falling not sure why here are the logs attached
logs_patcito_gitea_1_1.log

@cuonglm
Copy link
Collaborator Author

cuonglm commented Dec 23, 2019

@patcito I'm looking

@cuonglm
Copy link
Collaborator Author

cuonglm commented Dec 23, 2019

@patcito Seems related to this:


Preparing to unpack .../git-lfs_2.9.2_amd64.deb ...
--
34 | Unpacking git-lfs (2.9.2) ...
35 | Setting up git-lfs (2.9.2) ...
36 | Error: Failed to call git rev-parse --git-dir: exit status 128
37 | Git LFS initialized.

@cuonglm
Copy link
Collaborator Author

cuonglm commented Dec 23, 2019

Sounds like it dues to some modules use gopkg.in/src-d/go-billy.v4/osfs, investigating.

@cuonglm
Copy link
Collaborator Author

cuonglm commented Dec 23, 2019

@patcito Reading this src-d/go-billy#64 (comment), do you think we should use https://github.com/jfontan/go-billy-desfacer or writing our own?

@patcito
Copy link
Owner

patcito commented Dec 23, 2019 via email

@cuonglm
Copy link
Collaborator Author

cuonglm commented Dec 23, 2019

Could you check if go-billy-desfacer code looks ok? If yes then we could use it.

On Mon, Dec 23, 2019, 12:07 PM Cuong Manh Le @.***> wrote: @patcito https://github.com/patcito Reading this src-d/go-billy#64 (comment) <src-d/go-billy#64 (comment)>, do you think we should use https://github.com/jfontan/go-billy-desfacer or writing our own? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=AAAGOQ2PXBPI43UBBWW4BYDQ2CLV3A5CNFSM4J6P3B6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHQ4M5I#issuecomment-568444533>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGOQ4XTOTOZSZANG7KYSLQ2CLV3ANCNFSM4J6P3B6A .

I'm creating an PR, seems it's ok since when it jus a wrapper with afero inside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants