You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in open_chisel/src/camera/PinholeCamera.cpp function: void PinholeCamera::SetupFrustum(const Transform& view, Frustum* frustum) const, line 2 where Frustum::SetFromParams(xxx) was used, but the 4th param should not be intrinsics.GetFx() ?
the code is :
void PinholeCamera::SetupFrustum(const Transform& view, Frustum* frustum) const
{
assert(frustum != nullptr);
frustum->SetFromParams(view, nearPlane, farPlane, intrinsics.GetFy(), intrinsics.GetFy(), intrinsics.GetCx(), intrinsics.GetCy(), width, height);
}
The text was updated successfully, but these errors were encountered:
in open_chisel/src/camera/PinholeCamera.cpp function: void PinholeCamera::SetupFrustum(const Transform& view, Frustum* frustum) const, line 2 where Frustum::SetFromParams(xxx) was used, but the 4th param should not be intrinsics.GetFx() ?
the code is :
void PinholeCamera::SetupFrustum(const Transform& view, Frustum* frustum) const
{
assert(frustum != nullptr);
frustum->SetFromParams(view, nearPlane, farPlane, intrinsics.GetFy(), intrinsics.GetFy(), intrinsics.GetCx(), intrinsics.GetCy(), width, height);
}
The text was updated successfully, but these errors were encountered: