Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIP 10 - Gathering columns with TensorFlow core op #40

Closed
jostosh opened this issue Feb 23, 2018 · 2 comments
Closed

LIP 10 - Gathering columns with TensorFlow core op #40

jostosh opened this issue Feb 23, 2018 · 2 comments
Labels
feature LIP

Comments

@jostosh
Copy link
Collaborator

jostosh commented Feb 23, 2018

Issue associated with LIP10.
@jostosh
Copy link
Collaborator Author

jostosh commented Sep 28, 2018

Assigned this to libspn-release since getting rid of the custom gather_cols Op will make the code base smaller and cleaner in the sense that:

  • There is no need for a custom_gather_cols flag in libspn/conf.py
  • There is no need to maintain the custom Op anymore and so it can be taken out of libspn/ops

@jostosh
Copy link
Collaborator Author

jostosh commented Feb 23, 2019

Is now part of jostosh/libspn/dev-refactor-for-release

@jostosh jostosh closed this as completed Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature LIP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jostosh