Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypress event handlers shouldn't be anonymous #2106

Open
dylanh724 opened this issue Jan 24, 2025 · 1 comment
Open

Keypress event handlers shouldn't be anonymous #2106

dylanh724 opened this issue Jan 24, 2025 · 1 comment
Labels
kind: enhancement New feature or request

Comments

@dylanh724
Copy link

dylanh724 commented Jan 24, 2025

Hi,

Please properly identify the keypress event handlers (currently anonymous) so we can remove them if we want. Eg, an actual handler func called on keydown. Eg:

function pyDataCtrlKHandler(e) {
    // Original listener logic here
}
window.addEventListener("keydown", pyDataCtrlKHandler, true);

Real example use: We added Algolia DocSearch that replaced the search and uses the same hotkeys (eg, CTRL+K).

Cheers

@drammock
Copy link
Collaborator

good idea. Do you have time for a PR to implement this?

@trallard trallard added the kind: enhancement New feature or request label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants