Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: define a protocol to handle base loss and all chunked loss. #2226

Open
insop opened this issue Jan 2, 2025 · 1 comment
Open

Improvement: define a protocol to handle base loss and all chunked loss. #2226

insop opened this issue Jan 2, 2025 · 1 comment
Assignees
@felipemello1
Labels
enhancement New feature or request

Comments

@insop
Copy link
Contributor

insop commented Jan 2, 2025

As an improvement, it would be great to "define a protocol ChunkedLoss or something having a method e.g. def base_loss(self, *args, **kwargs) and have all of CEWithChunkedOutputLoss, ForwardKLWithChunkedOutputLoss, ReverseKLWithChunkedOutputLoss, SymmetricKLWithChunkedOutputLoss inherit from that."

Code: _compile.py

Context:
This is based on the discussion in PR #2094.
@insop insop mentioned this issue Jan 3, 2025
Open
13 tasks
@joecummings joecummings added discussion Start a discussion enhancement New feature or request and removed discussion Start a discussion labels Jan 6, 2025
@joecummings
Copy link
Contributor

@felipemello1 - can we do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipemello1 felipemello1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@insop @joecummings @felipemello1