Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

which header files are public apis? #818

Closed
trim21 opened this issue Jan 11, 2025 · 2 comments
Closed

which header files are public apis? #818

trim21 opened this issue Jan 11, 2025 · 2 comments

Comments

@trim21
Copy link

trim21 commented Jan 11, 2025

I'm trying to pack this project as meson subproject and I encounter a problem.

Looks like only quickjs.h is public api but it's located at project root, so a include path quickjs-ng/quickjs will make all internal headers files available in path search path.

mesonbuild/wrapdb#1865 (review)

is it possible to have a dedicated "include" directory to expose our APIs?

@trim21 trim21 changed the title which header files public apis? which header files are public apis? Jan 11, 2025
@saghul
Copy link
Contributor

saghul commented Jan 11, 2025

Yes, quickjs.h is the only public header. Implementaation details are hidden in quickjs.c so exposing the other headers should be harmless. If you can prevent it, however, I'd recommend you do.

@trim21
Copy link
Author

trim21 commented Jan 14, 2025

thanks

@trim21 trim21 closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants