Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile optimizations #373

Open
raboof opened this issue Jan 6, 2025 · 1 comment
Open

Makefile optimizations #373

raboof opened this issue Jan 6, 2025 · 1 comment

Comments

@raboof
Copy link
Owner

raboof commented Jan 6, 2025

Our makefiles contain ... = $(shell ...) and ... ?= $(shell ...) in several places, which are 'lazy', meaning the shell command is executed each time the variable is used.

We should consider replacing the lazy sets with immediate sets (:=), and for the 'lazy set if absent' cases consider whether it's worth adding additional logic.

@wilhelmy
Copy link
Collaborator

It's also possible to export the variables like in lua-detect.mk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants