Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict error report download to files with errors #3458

Open
8 tasks
elipe17 opened this issue Feb 6, 2025 · 0 comments
Open
8 tasks

Restrict error report download to files with errors #3458

elipe17 opened this issue Feb 6, 2025 · 0 comments
Labels
backend dev frontend Refined Ticket has been refined at the backlog refinement

Comments

@elipe17
Copy link

elipe17 commented Feb 6, 2025

Description:
It was recently pointed out that in the event a file is submitted and no errors are generated that the submitter can download an empty error report. This should be a little smarter. I.e. an error report should only be available to download if and only if the report has errors. The file attached below can be used as a test case for a file with no errors. When the file below is submitted the submitter is able to download an error report even though the file is Accepted and the error report has no errors.

MO_test_case_closed.txt

Acceptance Criteria:
Create a list of functional outcomes that must be achieved to complete this issue

  • Error report can only be downloaded if it has data
  • Error report link should or should not be available based on file status and error report content
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:
Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

  • Update datafile serializer to return information about error report
  • Update CaseAggregatesTable and TotalAggregatesTable to render a download link pending error report content
  • Add frontend and backend tests
  • Run Testing Checklist and confirm all tests pass
@lhuxraft lhuxraft added the Refined Ticket has been refined at the backlog refinement label Feb 11, 2025
@lhuxraft lhuxraft changed the title Smart Error Report Download Restrict error report download to files with errors Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dev frontend Refined Ticket has been refined at the backlog refinement
Projects
None yet
Development

No branches or pull requests

2 participants