Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing file extension validation on Data Files page #3478

Open
jtimpe opened this issue Feb 18, 2025 · 6 comments
Open

Fix missing file extension validation on Data Files page #3478

jtimpe opened this issue Feb 18, 2025 · 6 comments
Labels
bug dev Refined Ticket has been refined at the backlog refinement

Comments

@jtimpe
Copy link

jtimpe commented Feb 18, 2025

Thank you for taking the time to let us know about the issue you found. The basic rule for bug reporting is that
something isn't working the way one would expect it to work. Please provide us with the information requested
below and we will look at it as soon as we are able.

Description

In this comment, Eric points out that the (OG) Data Files page is no longer performing the file extension validation when a file is selected.

e.g.,

Image

Action Taken

  • Navigate to the Data Files page. Search, then select a not-allowed file type (png or jpeg, for example)

What I expected to see

When selecting a file, the extension should be checked against allowed extensions, like this example from the FRA Data Files page

Image

What I did see

  • No file extension error when selecting the file (precheck)
  • Data file is allowed to be submitted (but then fails at the backend with a file extension error)

Other Helpful Information

  • URL of the page I was on:
  • Browser and version:
  • Operating System: ( Windows | MacOS X | Linux | Other )
  • Is the issue repeatable?: ( yes | no | don't know )
  • Has the issue occurred more than once?:
@lhuxraft
Copy link
Collaborator

@jtimpe to confirm if this issue is happening in staging? Also update screenshots

@lhuxraft lhuxraft added the bug label Feb 18, 2025
@jtimpe
Copy link
Author

jtimpe commented Feb 18, 2025

issue is present in staging @lhuxraft @ADPennington

Image

@ADPennington
Copy link
Collaborator

ADPennington commented Feb 18, 2025

issue is present in staging @lhuxraft @ADPennington

Image

Thank you @jtimpe. Can we prioritize this? pen-testing is in-progress. @lhuxraft

@ADPennington
Copy link
Collaborator

helpful error message when attempting to submit png @jtimpe

Image

@jtimpe
Copy link
Author

jtimpe commented Feb 18, 2025

helpful error message when attempting to submit png @jtimpe

Image

right - the backend extension check is still functioning. the frontend one is not, however

@lhuxraft
Copy link
Collaborator

issue is present in staging @lhuxraft @ADPennington
Image

Thank you @jtimpe. Can we prioritize this? pen-testing is in-progress. @lhuxraft

For sure - I'll shortlist for inclusion in the next sprint

@lhuxraft lhuxraft added the Refined Ticket has been refined at the backlog refinement label Feb 18, 2025
@lhuxraft lhuxraft changed the title Data files extension validation not working Fix missing file extension validation on Data Files page Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dev Refined Ticket has been refined at the backlog refinement
Projects
None yet
Development

No branches or pull requests

3 participants