Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prop validation for axis fails with ordinal scales #36

Open
robatron opened this issue Apr 29, 2016 · 0 comments
Open

Prop validation for axis fails with ordinal scales #36

robatron opened this issue Apr 29, 2016 · 0 comments

Comments

@robatron
Copy link

I'm getting the following prop validation failure when an xScale is ordinal:

Warning: Failed propType: Invalid prop `xScale` of value `band` supplied to `Grid`, expected one of ["linear","identity","sqrt","pow","log","quantize","quantile","ordinal","time"].

It looks like when a scale is set to ordinal, it actually is set to 'band' via axis.jsx: https://github.com/react-d3/react-d3-core/blob/master/src/axis/axis.jsx#L80

Would including 'band' in the allowed prop types fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant