Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if user.home folder can be used before downloading tool #189

Open
sbouchet opened this issue May 11, 2023 · 1 comment
Open

Check if user.home folder can be used before downloading tool #189

sbouchet opened this issue May 11, 2023 · 1 comment

Comments

@sbouchet
Copy link
Contributor

see redhat-developer/intellij-openshift-connector#538 for reported issue.

tracked down to

Path path = Paths.get(tool.getBaseDir().replace("$HOME", CommonConstants.HOME_FOLDER), "cache", tool.getVersion(), command);

the issue is the user can't execute downloaded file because IJ openshift uses $HOME/.odo as destination.

proposed change if to move to System.getenv("APPDATA") for windows users?

@adietish
Copy link
Contributor

adietish commented May 11, 2023

@sbouchet I agree, System.getenv("APPDATA") seems to be the right choice for windows

App data is mutable data that is created and managed by a specific app. It includes runtime state, app settings, user preferences, reference content (such as the dictionary definitions in a dictionary app)

(source: https://learn.microsoft.com/en-us/windows/apps/design/app-settings/store-and-retrieve-app-data).

Is there a need to migrate existing data to the new location?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants