Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ingest_metadata to move fields to top level #481

Closed
1 task
maxsibilla opened this issue Oct 1, 2024 · 2 comments · Fixed by #510 or #513
Closed
1 task

Modify ingest_metadata to move fields to top level #481

maxsibilla opened this issue Oct 1, 2024 · 2 comments · Fixed by #510 or #513
Assignees

Comments

@maxsibilla
Copy link
Contributor

maxsibilla commented Oct 1, 2024

Specifically for Datasets we will have to modify the provenance schema to add files and metadata as these will no longer live inside of ingest_metadata. Triggers that utilize ingest_metadata.metadata will also have to be updated to support this.

Make the same changes that are being made on the HuBMAP side see the ingest_metadata field changes document and HuBMAP entity-api issue #748 and HuBMAP manual-data-ingest issue #333

  • Do we modify all ingest_metadata in dev/prod neo4j or do we modify the triggers to handle both use cases?
@maxsibilla
Copy link
Contributor Author

maxsibilla commented Oct 24, 2024

  • Modify trigger method set_processing_information to grab data from top level fields metadata and ingest_metadata
  • Modify data in Neo4j to reflect top level fields files and metadata
    • This will also apply to Publications
  • Check for any other instances of ingest_metadata.metadata inside of trigger methods or calculated fields

@tjmadonna
Copy link
Contributor

tjmadonna commented Oct 25, 2024

Script for updating datasets

https://gist.github.com/tjmadonna/48f7d00d84ee0b36094bf337e7cabc87

Dev datasets changed

a75c36065fd2cba66ac443fbd8dcd935
0462ab26fabb066adb7000e81191ff3d
745b2782b5445ab901f3010d956d2a61

@maxsibilla maxsibilla linked a pull request Oct 31, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Review/QA to Done in CODCC Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants