Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized Upload Pages Not Displaying Lab Dataset IDs #1744

Open
bhonick opened this issue Nov 15, 2024 · 4 comments
Open

Reorganized Upload Pages Not Displaying Lab Dataset IDs #1744

bhonick opened this issue Nov 15, 2024 · 4 comments
Assignees

Comments

@bhonick
Copy link

bhonick commented Nov 15, 2024

@maxsibilla A provider has reported to me a display issue that I am seeing on all reorganized uploads. For example, in upload SNT246.RGJQ.878, which has its reorganized datasets displayed, the portal does not show the lab dataset IDs. You can see those IDs in the individual dataset pages' metadata sections, such as in the second screenshot.

image

image

@bhonick bhonick added this to CODCC Nov 15, 2024
@bhonick bhonick moved this to Ready in CODCC Nov 15, 2024
@maxsibilla
Copy link
Contributor

@bhonick TheLab Dataset ID column that you see in the Upload corresponds with this field in the Dataset:
Image

So none of those Datasets in that Upload has that field specified. The field that you highlighted corresponds with ingest_metadata.metadata.lab_id

@bhonick
Copy link
Author

bhonick commented Nov 15, 2024

@maxsibilla This feels like extra work to be giving providers when it could happen automatically on our end - those datasets are created during reorganization, and the data upload will always have a metadata file containing those lab_ids. Couldn't we read the lab_ids and send them to entity API? This may be a PSC dev question for the actual reorganization step, but couldn't we fill in the Lab Name or ID field for current datasets coming from uploads based on information we've already captured in the graph database?

@maxsibilla
Copy link
Contributor

@bhonick I thought this was something that you already brought up to the PSC team? Essentially they would need to set the property <dataset>.dataset_lab_id to whatever lab_id is in the TSV file during reorganization.

@bhonick
Copy link
Author

bhonick commented Nov 18, 2024

@maxsibilla I'll check with the PSC devs.

@maxsibilla maxsibilla self-assigned this Dec 18, 2024
@maxsibilla maxsibilla moved this from Ready to Backlog in CODCC Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants