Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset newsletter prompt before each season #14

Open
juliaqiuxy opened this issue Nov 25, 2018 · 0 comments
Open

Reset newsletter prompt before each season #14

juliaqiuxy opened this issue Nov 25, 2018 · 0 comments
Assignees

Comments

@juliaqiuxy
Copy link
Member

Reset showEmailSignup before each season begins if the user explicitly dismissed it the previous season.

Instead of persisting a bool, we can persist the subscribed user's email and the time the user dismissed the prompt. Before each season starts, we should check time to see if the dismissal was explicitly triggered by user and not a subscription and if so clear dismissal time.

@juliaqiuxy juliaqiuxy self-assigned this Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant