Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1892848: Web Browser Auth doesnt need user to be passed but asserts it #2143

Open
karunmotorq opened this issue Jan 23, 2025 · 2 comments · May be fixed by #2142
Open

SNOW-1892848: Web Browser Auth doesnt need user to be passed but asserts it #2143

karunmotorq opened this issue Jan 23, 2025 · 2 comments · May be fixed by #2142
Assignees
Labels
question status-triage_done Initial triage done, will be further handled by the driver team

Comments

@karunmotorq
Copy link

Web Browser Auth doesnt need user to be passed but asserts it anyway
When passing dummy variable, auth still fails to happen
This deviates from the behaviour of the JS SDK

PR

@github-actions github-actions bot changed the title Web Browser Auth doesnt need user to be passed but asserts it SNOW-1892848: Web Browser Auth doesnt need user to be passed but asserts it Jan 23, 2025
@karunmotorq karunmotorq linked a pull request Jan 23, 2025 that will close this issue
@sfc-gh-dszmolka sfc-gh-dszmolka added bug status-triage_done Initial triage done, will be further handled by the driver team and removed bug labels Jan 27, 2025
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Jan 27, 2025
@sfc-gh-dszmolka
Copy link
Contributor

thanks for raising this and the PR too. The username is required for externalbrowser authentication and it's expected to fail without it. If the node.js driver somehow is able to authenticate with externalbrowser without username, that's not the expected behaviour.

Please, provide username in the connection at all times for all authentication methods. If there's a Snowflake documentation which says otherwise, I would like to know about it because I might miss something. Thank you !

@nicornk
Copy link

nicornk commented Feb 1, 2025

I want to leave a +1 that having to specify the username is cumbersome especially when you are providing template code to others and they need to modify it before login in with externalbrowser.

@sfc-gh-dszmolka could you elaborate on the threat you are trying to close with this assertion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants