Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implent try_from_debug_info_mut #45

Open
ksew1 opened this issue Dec 2, 2024 · 0 comments
Open

Implent try_from_debug_info_mut #45

ksew1 opened this issue Dec 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ksew1
Copy link
Member

ksew1 commented Dec 2, 2024

When we implement a function with the following signature:
fn try_from_debug_info_mut(sierra_debug_info: &mut DebugInfo) -> Result<Self, Self::Error>;
we could remove elements from the underlying hashmap and take ownership of them when deserialized, thus eliminating the need for cloning.

However, this would result in the function no longer being idempotent.

@ksew1 ksew1 added the enhancement New feature or request label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant