You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm debugging some nasty memory leak, and discovered that Chrome can sometimes leak DOM nodes (even on refresh). This by itself is not a huge issue (slightly annoying), however, because event handlers (like $$click) are not getting removed, basically the whole ownership graph stays in memory because it's a doubly-linked tree AFAICT. You can imagine that this becomes a huge issue pretty quick.
So the question is, should these be deleted on cleanup?
Additionally, I noticed there's _$owner being set on custom elements that should also probably be removed (I did not check if it is, for now I just disabled this behavior using contextToCustomElements: false).
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Please take a look here:
https://playground.solidjs.com/anonymous/7ce4d304-07b3-48df-b742-64b0da65ccc6
I'm debugging some nasty memory leak, and discovered that Chrome can sometimes leak DOM nodes (even on refresh). This by itself is not a huge issue (slightly annoying), however, because event handlers (like
$$click
) are not getting removed, basically the whole ownership graph stays in memory because it's a doubly-linked tree AFAICT. You can imagine that this becomes a huge issue pretty quick.So the question is, should these be deleted on cleanup?
There's a similar issue in React as well:
facebook/react#26069
Additionally, I noticed there's
_$owner
being set on custom elements that should also probably be removed (I did not check if it is, for now I just disabled this behavior usingcontextToCustomElements: false
).Beta Was this translation helpful? Give feedback.
All reactions